GitHub/gf-core
1
0
Fork 1
mirror of https://github.com/GrammaticalFramework/gf-core.git synced 2026-04-17 08:49:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Solve the mystery of the segfaults when reading args in createCategory

Browse Source 
it was a missing `&`
This commit is contained in:
John J. Camilleri
2021-09-27 11:51:58 +02:00
parent 2deae9d402
commit 6ce619c146
2 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/runtime/python/transactions.c
View File

@@ -94,7 +94,7 @@ Transaction_createFunction(TransactionObject *self, PyObject *args)
Py_ssize_t size;
TypeObject *type;
Py_ssize_t arity = 0;
float prob = 0.0;
prob_t prob = 0.0;
if (!PyArg_ParseTuple(args, "s#O!nf", &s, &size, &pgf_TypeType, &type, &arity, &prob))
return NULL;
@@ -136,15 +136,9 @@ Transaction_createCategory(TransactionObject *self, PyObject *args)
const char *s;
Py_ssize_t size;
PyObject *hypos;
float prob = 0.0;
// if (!PyArg_ParseTuple(args, "s#O!f", &s, &size, &PyList_Type, &hypos, prob)) // segfaults in Python 3.8 but not 3.7
// return NULL;
if (!PyArg_ParseTuple(args, "s#Of", &s, &size, &hypos, prob))
prob_t prob = 0.0;
if (!PyArg_ParseTuple(args, "s#O!f", &s, &size, &PyList_Type, &hypos, &prob))
return NULL;
if (!PyObject_TypeCheck(hypos, &PyList_Type)) {
PyErr_SetString(PyExc_TypeError, "hypos must be a list");
return NULL;
}
PgfText *catname = CString_AsPgfText(s, size);