mirror of
https://github.com/GrammaticalFramework/gf-core.git
synced 2026-04-09 04:59:31 -06:00
ab3cc77656
This patch fixes a problem introduced last year when the GF shell was
refactored to allow more commands to be treated uniformly and be part
of pipes. The cc command was one of those commands, but unfortunately this
introduced a parsing problem, e.g.
> cc "last"
constant not found: last
> cc "last"++"year"
command not parsed: cc "last"++"year"
This happened because the generic command line parser in
GF.Command.{Abstract,Parse} assumes that all commands have an argument of
type PGF.Expr. Commands that expect other types of arguments have to
use PGF.showExpr combined with other conversion to the argument type they
expect. The cc command excpets a GF.Grammar.Term, and unfortunately not
all terms survice the roundtrip through PGF.Expr, in part because of
an additional hack to allow strings to be roundtripped through PGF.Expr
without adding superfluous double quotes.
To solve the problem, this patch
+ makes room for arguments of type Term in the Argument type in
GF.Command.Abstract.
+ makes a special case for the cc command in GF.Command.Parse, by
calling the partial parser 'runPartial pTerm' recently added in
GF.Grammar.Lexer and GF.Grammar.Parser. Care was taken so that
that "|" and ";" can be used both inside terms and as separators between
commands in the shell, e.g. things like the following now work:
> cc ("a"|"b") | ps -lexcode
variants { "a" ; "b" }
+ introduces a type CommandArgument that replaces [Expr] as the
type of values passed between commands in pipes. It has room for
values of type [Expr], [String] and Term, thus eliminating the need
to roundtrip through the Expr type all the time.
The hack to avoid adding superfluous quotes when strings are
roundtripped through Expr has been left in place for now,
but can probably be removed.
85 lines
2.5 KiB
Haskell
85 lines
2.5 KiB
Haskell
module GF.Command.CommandInfo where
|
|
import GF.Command.Abstract(Option,Expr,Term)
|
|
import GF.Text.Pretty(render)
|
|
import GF.Grammar.Printer() -- instance Pretty Term
|
|
import GF.Grammar.Macros(string2term)
|
|
import qualified PGF as H(showExpr)
|
|
import qualified PGF.Internal as H(Literal(LStr),Expr(ELit)) ----
|
|
|
|
data CommandInfo m = CommandInfo {
|
|
exec :: [Option] -> CommandArguments -> m CommandOutput,
|
|
synopsis :: String,
|
|
syntax :: String,
|
|
explanation :: String,
|
|
longname :: String,
|
|
options :: [(String,String)],
|
|
flags :: [(String,String)],
|
|
examples :: [(String,String)],
|
|
needsTypeCheck :: Bool
|
|
}
|
|
|
|
mapCommandExec f c = c { exec = \ opts ts -> f (exec c opts ts) }
|
|
|
|
--emptyCommandInfo :: CommandInfo env
|
|
emptyCommandInfo = CommandInfo {
|
|
exec = error "command not implemented",
|
|
synopsis = "",
|
|
syntax = "",
|
|
explanation = "",
|
|
longname = "",
|
|
options = [],
|
|
flags = [],
|
|
examples = [],
|
|
needsTypeCheck = True
|
|
}
|
|
--------------------------------------------------------------------------------
|
|
|
|
class Monad m => TypeCheckArg m where typeCheckArg :: Expr -> m Expr
|
|
|
|
--------------------------------------------------------------------------------
|
|
|
|
data CommandArguments = Exprs [Expr] | Strings [String] | Term Term
|
|
|
|
newtype CommandOutput = Piped (CommandArguments,String) ---- errors, etc
|
|
|
|
-- ** Converting command output
|
|
fromStrings ss = Piped (Strings ss, unlines ss)
|
|
fromExprs es = Piped (Exprs es,unlines (map (H.showExpr []) es))
|
|
fromString s = Piped (Strings [s], s)
|
|
pipeWithMessage es msg = Piped (Exprs es,msg)
|
|
pipeMessage msg = Piped (Exprs [],msg)
|
|
pipeExprs es = Piped (Exprs es,[]) -- only used in emptyCommandInfo
|
|
void = Piped (Exprs [],"")
|
|
|
|
stringAsExpr = H.ELit . H.LStr -- should be a pattern macro
|
|
|
|
-- ** Converting command input
|
|
|
|
toStrings args =
|
|
case args of
|
|
Strings ss -> ss
|
|
Exprs es -> zipWith showAsString (True:repeat False) es
|
|
Term t -> [render t]
|
|
where
|
|
showAsString first t =
|
|
case t of
|
|
H.ELit (H.LStr s) -> s
|
|
_ -> ['\n'|not first] ++
|
|
H.showExpr [] t ---newline needed in other cases than the first
|
|
|
|
toExprs args =
|
|
case args of
|
|
Exprs es -> es
|
|
Strings ss -> map stringAsExpr ss
|
|
Term t -> [stringAsExpr (render t)]
|
|
|
|
toTerm args =
|
|
case args of
|
|
Term t -> t
|
|
Strings ss -> string2term $ unwords ss -- hmm
|
|
Exprs es -> string2term $ unwords $ map (H.showExpr []) es -- hmm
|
|
|
|
-- ** Creating documentation
|
|
|
|
mkEx s = let (command,expl) = break (=="--") (words s) in (unwords command, unwords (drop 1 expl))
|