msyds/gf-core
1
0
Fork 0
forked from GitHub/gf-core
Code Pull Requests Activity

gfse: allow public grammars to be deleted in more cases

Browse Source 
The editor doesn't show delete buttons on grammars published by other
users, but it was too picky when deciding which grammars you own. Now
it should be possible to delete grammars from the device/browser
you published it from, even if you don't have a private copy of it any more.

On a related note, there seems to be problem with the way unique grammars
names are created and maintained, causing published grammars to be duplicated
in some cases. This needs to be overhauled.
This commit is contained in:
Thomas Hallgren
2018-03-29 17:02:22 +02:00
parent 78cf184957
commit 750a1349ff
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/www/gfse/editor.js
View File

@@ -158,15 +158,16 @@ function draw_grammar_list() {
clear(gt)
if(files.length>0) {
sort_grammars()
//var unique_id=local.get("unique_id","-")
var unique_id=local.get("unique_id","-")
for(var i in files) {
var file=files[i].path
var parts=file.split(/[-.]/)
var basename=parts[0]
var unique_name=parts[1]+"-"+parts[2]
var mine = my_grammar(unique_name)!=null
var del = mine
? delete_button(rmpublic(file),"Don't publish this grammar")
var from_me = parts[1] == unique_id
var del = from_me || mine
? delete_button(rmpublic(file),"Remove this public grammar")
: []
var tip = mine
? "This is a copy of your grammar"