From c5b64320163b0e2bdc2e408ed3a0f4be95dfbb85 Mon Sep 17 00:00:00 2001
From: krangelov <kr.angelov@gmail.com>
Date: Fri, 24 Sep 2021 17:20:25 +0200
Subject: [PATCH] implemented tables and parameters

---
 gf.cabal                                      |  1 -
 src/compiler/GF/Compile/Compute/Concrete.hs   | 62 ++++++++++++++++++-
 src/compiler/GF/Compile/Compute/Predef.hs     |  1 -
 src/compiler/GF/Compile/Compute/Value.hs      | 32 ----------
 testsuite/compiler/compute/param_table.gfs    |  7 +++
 .../compiler/compute/param_table.gfs.gold     |  7 +++
 6 files changed, 75 insertions(+), 35 deletions(-)
 delete mode 100644 src/compiler/GF/Compile/Compute/Value.hs

diff --git a/gf.cabal b/gf.cabal
index 5b5605ba2..3b52e0212 100644
--- a/gf.cabal
+++ b/gf.cabal
@@ -110,7 +110,6 @@ executable gf
     GF.Compile.CFGtoPGF
     GF.Compile.CheckGrammar
     GF.Compile.Compute.Predef
-    GF.Compile.Compute.Value
     GF.Compile.Compute.Concrete
     GF.Compile.ExampleBased
     GF.Compile.Export
diff --git a/src/compiler/GF/Compile/Compute/Concrete.hs b/src/compiler/GF/Compile/Compute/Concrete.hs
index 4627b9d9d..dfb0b5166 100644
--- a/src/compiler/GF/Compile/Compute/Concrete.hs
+++ b/src/compiler/GF/Compile/Compute/Concrete.hs
@@ -13,7 +13,6 @@ import GF.Grammar.Lookup(lookupResDef,allParamValues)
 import GF.Grammar.Predef(cPredef,cErrorType,cTok,cStr,cTrace,cPBool)
 import GF.Grammar.PatternMatch(matchPattern,measurePatt)
 import GF.Grammar.Lockfield(isLockLabel,lockRecType) --unlockRecord,lockLabel
-import GF.Compile.Compute.Value hiding (Error)
 import GF.Compile.Compute.Predef(predef,predefName,delta)
 import GF.Data.Str(Str,glueStr,str2strings,str,sstr,plusStr,strTok)
 import GF.Data.Operations(Err(..),err,errIn,maybeErr,mapPairsM)
@@ -33,6 +32,32 @@ normalForm gr loc t =
     [t] -> t
     ts  -> FV ts
 
+
+data ThunkState s
+  = Unevaluated (Env s) Term
+  | Evaluated (Value s)
+  | Unbound {-# UNPACK #-} !MetaId
+
+type Thunk s = STRef s (ThunkState s)
+type Env s = [(Ident,Thunk s)]
+
+data Value s
+  = VApp QIdent [Thunk s]
+  | VMeta (Thunk s) (Env s) [Thunk s]
+  | VGen  {-# UNPACK #-} !Int [Thunk s]
+  | VClosure (Env s) Term
+  | VR [(Label, Thunk s)]
+  | VP (Value s) Label
+  | VT TInfo [Case]
+  | VV Type [Thunk s]
+  | VS (Value s) (Value s)
+  | VSort Ident
+  | VInt Integer
+  | VFlt Double
+  | VStr String
+  | VC [Value s]
+
+
 eval env (Vr x)         vs  = case lookup x env of
                                 Just tnk -> force tnk vs
                                 Nothing  -> error "Unknown variable"
@@ -57,6 +82,16 @@ eval env (P t lbl)      vs  = do v <- eval env t []
                                               Nothing  -> error ("Missing value for label "++show lbl)
                                               Just tnk -> force tnk vs
                                    v     -> return (VP v lbl)
+eval env (T i cs)       vs  = return (VT i cs)
+eval env (V ty ts)      vs  = do tnks <- mapM (newThunk env) ts
+                                 return (VV ty tnks)
+eval env (S t1 t2)      vs  = do v1   <- eval env t1 []
+                                 tnk2 <- newThunk env t2
+                                 case v1 of
+                                   VT _ cs -> do (env,t) <- patternMatch env cs tnk2
+                                                 eval env t vs
+                                   v1      -> do v2 <- force tnk2 []
+                                                 return (VS v1 v2)
 eval env (Let (x,(_,t1)) t2) vs = do tnk <- newThunk env t1
                                      eval ((x,tnk):env) t2 vs
 eval env (Q q)               vs = do t <- lookupGlobal q
@@ -78,6 +113,28 @@ apply (VMeta m env vs0)             vs  = return (VMeta m env (vs0++vs))
 apply (VGen i  vs0)                 vs  = return (VGen i (vs0++vs))
 apply (VClosure env (Abs b x t)) (v:vs) = eval ((x,v):env) t vs
 
+patternMatch env []         tnk = error "No matching pattern found"
+patternMatch env ((p,t):cs) tnk = do
+  res <- match env p tnk
+  case res of
+    Nothing  -> patternMatch env cs tnk
+    Just env -> return (env,t)
+  where
+    match env (PP q ps) tnk = do v <- force tnk []
+                                 case v of
+                                   VApp r tnks | q == r -> match' env ps tnks
+                                   _                    -> return Nothing
+    match env (PV v)    tnk = return (Just ((v,tnk):env))
+    match env PW        tnk = return (Just env)
+    match env (PAs v p) tnk = match ((v,tnk):env) p tnk
+
+    match' env []     []         =
+      return (Just env)
+    match' env (p:ps) (tnk:tnks) = do
+      res <- match env p tnk
+      case res of
+        Nothing  -> return Nothing
+        Just env -> match' env ps tnks
 
 value2term i (VApp q tnks) =
   foldM (\e1 tnk -> fmap (App e1) (force tnk [] >>= value2term i)) (QC q) tnks
@@ -99,6 +156,9 @@ value2term i (VR as) = do
 value2term i (VP v lbl) = do
   t <- value2term i v
   return (P t lbl)
+value2term i (VT ti cs) = return (T ti cs)
+value2term i (VV ty tnks) = do ts <- mapM (\tnk -> force tnk [] >>= value2term i) tnks
+                               return (V ty ts)
 value2term i (VSort s) = return (Sort s)
 value2term i (VStr tok) = return (K tok)
 value2term i (VInt n) = return (EInt n)
diff --git a/src/compiler/GF/Compile/Compute/Predef.hs b/src/compiler/GF/Compile/Compute/Predef.hs
index 9a17aa186..2896ec5a6 100644
--- a/src/compiler/GF/Compile/Compute/Predef.hs
+++ b/src/compiler/GF/Compile/Compute/Predef.hs
@@ -14,7 +14,6 @@ import Control.Monad(ap)
 
 import GF.Data.Utilities (apBoth) --mapSnd
 
-import GF.Compile.Compute.Value
 import GF.Infra.Ident (Ident,showIdent) --,varX
 import GF.Data.Operations(Err) -- ,err
 import GF.Grammar.Predef
diff --git a/src/compiler/GF/Compile/Compute/Value.hs b/src/compiler/GF/Compile/Compute/Value.hs
deleted file mode 100644
index c088c0836..000000000
--- a/src/compiler/GF/Compile/Compute/Value.hs
+++ /dev/null
@@ -1,32 +0,0 @@
-module GF.Compile.Compute.Value where
-
-import Data.STRef
-import qualified Data.Map as Map
-import Control.Monad
-import Control.Monad.ST
-import Control.Applicative
-
-import GF.Grammar.Grammar(MetaId,Term,Label,QIdent)
-import PGF2(BindType)
-import GF.Infra.Ident(Ident)
-
-data ThunkState s
-  = Unevaluated (Env s) Term
-  | Evaluated (Value s)
-  | Unbound {-# UNPACK #-} !MetaId
-
-type Thunk s = STRef s (ThunkState s)
-type Env s = [(Ident,Thunk s)]
-
-data Value s
-  = VApp QIdent [Thunk s]
-  | VMeta (Thunk s) (Env s) [Thunk s]
-  | VGen  {-# UNPACK #-} !Int [Thunk s]
-  | VClosure (Env s) Term
-  | VR [(Label, Thunk s)]
-  | VP (Value s) Label
-  | VSort Ident
-  | VInt Integer
-  | VFlt Double
-  | VStr String
-  | VC [Value s]
diff --git a/testsuite/compiler/compute/param_table.gfs b/testsuite/compiler/compute/param_table.gfs
index 7b2f1d3eb..f10be2df6 100644
--- a/testsuite/compiler/compute/param_table.gfs
+++ b/testsuite/compiler/compute/param_table.gfs
@@ -1,2 +1,9 @@
 i -retain testsuite/compiler/compute/param_table.gf
 cc P2 Q1
+cc table {P1 => "p1"; P2 _ => "p2"} ! P1
+cc table {P1 => "p1"; P2 _ => "p2"} ! P2 Q1
+cc table {P1 => "p1"; P2 _ => "p2"} ! P2 (Q1|Q2)
+cc table {P1 => "p1"; P2 q => "p2"} ! P2 (Q1|Q2)
+cc table {P1 => "p1"; P2 Q1 => "p2q1"; P2 Q2 => "p2q2"} ! P2 (Q1|Q2)
+cc table {P1 => "p1"; P2 Q1 => "p2q1"; P2 Q2 => "p2q2"} ! P2 Q1
+cc table {P1 => "p1"; P2 q => case q of {Q1 => "p2q1"; Q2 => "p2q2"}} ! P2 Q1
diff --git a/testsuite/compiler/compute/param_table.gfs.gold b/testsuite/compiler/compute/param_table.gfs.gold
index 5e039c666..bc97639b5 100644
--- a/testsuite/compiler/compute/param_table.gfs.gold
+++ b/testsuite/compiler/compute/param_table.gfs.gold
@@ -1 +1,8 @@
 param_table.P2 param_table.Q1
+"p1"
+"p2"
+"p2"
+"p2"
+variants {"p2q1"; "p2q2"}
+"p2q1"
+"p2q1"