From c37e8bdf153708479a9ff7dddaef2fc369b781d9 Mon Sep 17 00:00:00 2001
From: crumbtoo <crumb@disroot.org>
Date: Fri, 9 Feb 2024 17:04:33 -0700
Subject: [PATCH] Rlp2Core: pattern let binds

---
 src/Control/Monad/Utils.hs | 11 ++++++++++
 src/Rlp2Core.hs            | 41 ++++++++++++++++++++++++--------------
 2 files changed, 37 insertions(+), 15 deletions(-)

diff --git a/src/Control/Monad/Utils.hs b/src/Control/Monad/Utils.hs
index 6cc5521..60681e3 100644
--- a/src/Control/Monad/Utils.hs
+++ b/src/Control/Monad/Utils.hs
@@ -1,10 +1,13 @@
 module Control.Monad.Utils
     ( mapAccumLM
+    , Kendo(..)
     )
     where
 ----------------------------------------------------------------------------------
 import Data.Tuple               (swap)
+import Data.Coerce
 import Control.Monad.State
+import Control.Monad
 ----------------------------------------------------------------------------------
 
 -- | Monadic variant of @mapAccumL@
@@ -19,3 +22,11 @@ mapAccumLM k s t = swap <$> runStateT (traverse k' t) s
         k' :: a -> StateT s m b
         k' a = StateT $ fmap swap <$> flip k a
 
+newtype Kendo m a = Kendo { appKendo :: a -> m a }
+
+instance (Monad m) => Semigroup (Kendo m a) where
+    Kendo f <> Kendo g = Kendo (f <=< g)
+
+instance (Monad m) => Monoid (Kendo m a) where
+    mempty = Kendo pure
+
diff --git a/src/Rlp2Core.hs b/src/Rlp2Core.hs
index 9740c10..142f752 100644
--- a/src/Rlp2Core.hs
+++ b/src/Rlp2Core.hs
@@ -9,7 +9,7 @@ module Rlp2Core
 --------------------------------------------------------------------------------
 import Control.Monad
 import Control.Monad.Writer.CPS
-import Control.Monad.Utils              (mapAccumLM)
+import Control.Monad.Utils
 import Control.Arrow
 import Control.Applicative
 import Control.Comonad
@@ -135,8 +135,10 @@ letToCore :: forall es. (NameSupply :> es)
           => Rec -> [Rlp.Binding' RlpcPs] -> RlpExpr' RlpcPs -> Eff es Expr'
 letToCore r bs e = do
     (bs',as) <- getParts
-    e' <- caseify as (unXRec e)
-    pure $ Let r bs' e'
+    e' <- appKendo (foldMap Kendo as) <=< exprToCore $ unXRec e
+    if null bs'
+        then pure e'
+        else pure $ Let r bs' e'
   where
     -- partition & map the list of binders into:
     --  bs'   : the let-binds that may be directly translated to Core
@@ -147,22 +149,27 @@ letToCore r bs e = do
     getParts = traverse f bs <&> partitionEithers
 
     f :: Rlp.Binding' RlpcPs
-      -> Eff es (Either Core.Binding' (Alt RlpcPs))
+      -> Eff es (Either Core.Binding' (Expr' -> Eff es Expr'))
     f (PatB'' (VarP'' n) e) = Left . (n :=) <$> exprToCore (unXRec e)
-    f (PatB'' p          e) = undefined
-
-    varPatB :: Traversal' (Rlp.Binding' RlpcPs) (IdP RlpcPs)
-    varPatB = located . _PatB . _1 . located . _VarP
+    f (PatB'' p          e) = pure $ Right (caseify p e)
 
 litToCore :: (NameSupply :> es) => Rlp.Lit RlpcPs -> Eff es Expr'
 litToCore (Rlp.IntL n) = pure . Lit $ Core.IntL n
 
-caseify :: (NameSupply :> es) => [Alt RlpcPs] -> RlpExpr RlpcPs -> Eff es Expr'
-caseify as ee = do
-    ee' <- exprToCore ee
-    foldrM go ee' as
+{-
+let C x = y
+in e
+
+case y of
+    C x -> e
+ -}
+
+caseify :: (NameSupply :> es)
+        => Pat' RlpcPs -> RlpExpr' RlpcPs -> Expr' -> Eff es Expr'
+caseify p (unXRec -> e) i =
+    Case <$> exprToCore e <*> ((:[]) <$> alt)
   where
-    go a e = Case e . pure <$> altToCore a
+    alt = conToRose (unXRec p) <&> foldFix (branchToCore i)
 
 -- TODO: where-binds
 caseAltToCore :: (NameSupply :> es)
@@ -173,8 +180,12 @@ caseAltToCore (AltA (unXRec -> p) e, wh) = do
 
 altToCore :: (NameSupply :> es)
           => Alt RlpcPs -> Eff es Alter'
-altToCore (AltA (unXRec -> p) e) = do
-    e' <- exprToCore . unXRec $ e
+altToCore (AltA p e) = altToCore' p e
+
+altToCore' :: (NameSupply :> es)
+           => Pat' RlpcPs -> RlpExpr' RlpcPs -> Eff es Alter'
+altToCore' (unXRec -> p) (unXRec -> e) = do
+    e' <- exprToCore e
     conToRose p <&> foldFix (branchToCore e')
 
 conToRose :: forall es. (NameSupply :> es) => Pat RlpcPs -> Eff es Rose