fix: Repls finally respect popup rules TwT

- Required patching on.el to run their hooks at the correct time.

users/crumb/programs/emacs/modules/doom-popup/doom-popup-config.el

@@ -76,21 +76,23 @@ adjustment.")
   :init-value nil
   :global t
   :keymap doom-popup-mode-map
-  (cond (doom-popup-mode
-         (add-hook 'doom-escape-hook #'doom-popup-close-on-escape-h 'append)
-         (setq doom-popup--old-display-buffer-alist display-buffer-alist
-               display-buffer-alist doom-popup--display-buffer-alist
-               window--sides-inhibit-check t)
-         (dolist (prop doom-popup-window-parameters)
-           (push (cons prop 'writable) window-persistent-parameters)))
-        (t
-         (remove-hook 'doom-escape-hook #'doom-popup-close-on-escape-h)
-         (setq display-buffer-alist doom-popup--old-display-buffer-alist
-               window--sides-inhibit-check nil)
-         (doom-popup-cleanup-rules-h)
-         (dolist (prop doom-popup-window-parameters)
-           (delq (assq prop window-persistent-parameters)
-                 window-persistent-parameters)))))
+  (progn
+    (message "doom-popup-mode: %S" doom-popup-mode)
+    (cond (doom-popup-mode
+          (add-hook 'doom-escape-hook #'doom-popup-close-on-escape-h 'append)
+          (setq doom-popup--old-display-buffer-alist display-buffer-alist
+                display-buffer-alist doom-popup--display-buffer-alist
+                window--sides-inhibit-check t)
+          (dolist (prop doom-popup-window-parameters)
+            (push (cons prop 'writable) window-persistent-parameters)))
+         (t
+          (remove-hook 'doom-escape-hook #'doom-popup-close-on-escape-h)
+          (setq display-buffer-alist doom-popup--old-display-buffer-alist
+                window--sides-inhibit-check nil)
+          (doom-popup-cleanup-rules-h)
+          (dolist (prop doom-popup-window-parameters)
+            (delq (assq prop window-persistent-parameters)
+                  window-persistent-parameters))))))
 
 (define-minor-mode doom-popup-buffer-mode
   "Minor mode for individual popup windows.

users/crumb/programs/emacs/modules/doom-popup/doom-popup-settings.el

@@ -191,7 +191,7 @@ used.
     (setq display-buffer-alist doom-popup--display-buffer-alist))
   doom-popup--display-buffer-alist)
 
-;;;###autodef
+;;;###autoload
 (defun set-popup-rules! (&rest rulesets)
   "Defines multiple popup rules.
 

users/crumb/programs/emacs/modules/doom-popup/doom-popup.el

@@ -25,15 +25,6 @@
 
 (require 'doom-popup-settings)
 
-(use-package popper
-  :custom ((popper-display-control nil)
-           (popper-reference-buffers
-            (list (lambda (buf)
-                    (with-current-buffer buf
-                      (bound-and-true-p doom-popup-mode))))))
-  :config
-  (popper-mode 1))
-
 (defvar doom-popup--internal nil)
 
 (defun doom-popup--remember (windows)

users/crumb/programs/emacs/modules/syd-popups.el

@@ -0,0 +1,24 @@
+;; syd-popups.el -*- lexical-binding: t; -*-
+
+(use-package popper
+  :disabled
+  :init
+  (setq popper-display-control nil
+        popper-reference-buffers
+        (list (lambda (buf)
+                (with-current-buffer buf
+                  (bound-and-true-p doom-popup-mode)))))
+  :config
+  (popper-mode 1))
+
+(use-package doom-popup
+  ;; :after popper
+  :load-path "/persist/dots/users/crumb/programs/emacs/modules/doom-popup"
+  :straight nil
+  ;; :straight
+  ;; (:type nil
+  ;;  :local-repo "/persist/dots/users/crumb/programs/emacs/modules/doom-popup")
+  )
+
+(provide 'syd-popups)
+;;; syd-popups.el ends here